Commit 626fb735 authored by John Garry's avatar John Garry Committed by Jens Axboe
Browse files

blk-mq: Make blk_mq_run_hw_queue() return void 



Since commit 97889f9a ("blk-mq: remove synchronize_rcu() from
blk_mq_del_queue_tag_set()"), the return value of blk_mq_run_hw_queue()
is never checked, so make it return void, which very marginally simplifies
the code.

Reviewed-by: default avatarBob Liu <bob.liu@oracle.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 9a7f12ed

block/blk-mq.c

+2 −6
Original line number Diff line number Diff line
@@ -1457,7 +1457,7 @@ void blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, unsigned long msecs) 
}

EXPORT_SYMBOL(blk_mq_delay_run_hw_queue);



bool blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async)

void blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async)

{

	int srcu_idx;

	bool need_run;
@@ -1475,12 +1475,8 @@ bool blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async) 
		blk_mq_hctx_has_pending(hctx);

	hctx_unlock(hctx, srcu_idx);



	if (need_run) {

	if (need_run)

		__blk_mq_delay_run_hw_queue(hctx, async, 0);

		return true;

	}



	return false;

}

EXPORT_SYMBOL(blk_mq_run_hw_queue);

include/linux/blk-mq.h

+1 −1
Original line number Diff line number Diff line
@@ -502,7 +502,7 @@ void blk_mq_start_stopped_hw_queues(struct request_queue *q, bool async); 
void blk_mq_quiesce_queue(struct request_queue *q);

void blk_mq_unquiesce_queue(struct request_queue *q);

void blk_mq_delay_run_hw_queue(struct blk_mq_hw_ctx *hctx, unsigned long msecs);

bool blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async);

void blk_mq_run_hw_queue(struct blk_mq_hw_ctx *hctx, bool async);

void blk_mq_run_hw_queues(struct request_queue *q, bool async);

void blk_mq_tagset_busy_iter(struct blk_mq_tag_set *tagset,

		busy_tag_iter_fn *fn, void *priv);

CRA Git | Maintained and supported by SUSTech CRA and CCSE