Commit 626a43de authored by Wei Yongjun's avatar Wei Yongjun Committed by John W. Linville
Browse files

mwifiex: use is_zero_ether_addr() instead of memcmp() 

Using is_zero_ether_addr() instead of directly use
memcmp() to determine if the ethernet address is all
zeros.

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/

)

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent a71bf90f

drivers/net/wireless/mwifiex/sta_cmdresp.c

+1 −2
Original line number Diff line number Diff line
@@ -736,7 +736,6 @@ static int mwifiex_ret_ibss_coalescing_status(struct mwifiex_private *priv, 
{

	struct host_cmd_ds_802_11_ibss_status *ibss_coal_resp =

					&(resp->params.ibss_coalescing);

	u8 zero_mac[ETH_ALEN] = { 0, 0, 0, 0, 0, 0 };



	if (le16_to_cpu(ibss_coal_resp->action) == HostCmd_ACT_GEN_SET)

		return 0;
@@ -745,7 +744,7 @@ static int mwifiex_ret_ibss_coalescing_status(struct mwifiex_private *priv, 
		"info: new BSSID %pM\n", ibss_coal_resp->bssid);



	/* If rsp has NULL BSSID, Just return..... No Action */

	if (!memcmp(ibss_coal_resp->bssid, zero_mac, ETH_ALEN)) {

	if (is_zero_ether_addr(ibss_coal_resp->bssid)) {

		dev_warn(priv->adapter->dev, "new BSSID is NULL\n");

		return 0;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE