Commit 6263835a authored by Namhyung Kim's avatar Namhyung Kim Committed by Jiri Olsa
Browse files

perf hists: Rename hists__inc_stats() 



The existing hists__inc_nr_entries() is a misnomer as it's not only
increasing ->nr_entries but also other stats.  So rename it to more
general hists__inc_stats().

Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1398327843-31845-3-git-send-email-namhyung@kernel.org


Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
parent 58c311da

tools/perf/builtin-diff.c

+1 −1
Original line number Diff line number Diff line
@@ -586,7 +586,7 @@ static void hists__compute_resort(struct hists *hists) 
		next = rb_next(&he->rb_node_in);



		insert_hist_entry_by_compute(&hists->entries, he, compute);

		hists__inc_nr_entries(hists, he);

		hists__inc_stats(hists, he);

	}

}

tools/perf/util/hist.c

+3 −3
Original line number Diff line number Diff line
@@ -317,7 +317,7 @@ static struct hist_entry *hist_entry__new(struct hist_entry *template) 
	return he;

}



void hists__inc_nr_entries(struct hists *hists, struct hist_entry *h)

void hists__inc_stats(struct hists *hists, struct hist_entry *h)

{

	if (!h->filtered) {

		hists__calc_col_len(hists, h);
@@ -686,7 +686,7 @@ void hists__output_resort(struct hists *hists) 
		next = rb_next(&n->rb_node_in);



		__hists__insert_output_entry(&hists->entries, n, min_callchain_hits);

		hists__inc_nr_entries(hists, n);

		hists__inc_stats(hists, n);

	}

}
@@ -853,7 +853,7 @@ static struct hist_entry *hists__add_dummy_entry(struct hists *hists, 
		he->hists = hists;

		rb_link_node(&he->rb_node_in, parent, p);

		rb_insert_color(&he->rb_node_in, root);

		hists__inc_nr_entries(hists, he);

		hists__inc_stats(hists, he);

		he->dummy = true;

	}

out:

tools/perf/util/hist.h

+1 −1
Original line number Diff line number Diff line
@@ -116,7 +116,7 @@ void hists__decay_entries(struct hists *hists, bool zap_user, bool zap_kernel); 
void hists__output_recalc_col_len(struct hists *hists, int max_rows);



u64 hists__total_period(struct hists *hists);

void hists__inc_nr_entries(struct hists *hists, struct hist_entry *h);

void hists__inc_stats(struct hists *hists, struct hist_entry *h);

void hists__inc_nr_events(struct hists *hists, u32 type);

void events_stats__inc(struct events_stats *stats, u32 type);

size_t events_stats__fprintf(struct events_stats *stats, FILE *fp);

CRA Git | Maintained and supported by SUSTech CRA and CCSE