Commit 625ef8a3 authored Oct 02, 2018 by Lukas Czerner Committed by Theodore Ts'o Oct 02, 2018

ext4: initialize retries variable in ext4_da_write_inline_data_begin()



Variable retries is not initialized in ext4_da_write_inline_data_begin()
which can lead to nondeterministic number of retries in case we hit
ENOSPC. Initialize retries to zero as we do everywhere else.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Fixes: bc0ca9df ("ext4: retry allocation when inline->extent conversion failed")
Cc: stable@kernel.org

parent 18aded17

fs/ext4/inline.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -863,7 +863,7 @@ int ext4_da_write_inline_data_begin(struct address_space *mapping,
		handle_t *handle;
		struct page *page;
		struct ext4_iloc iloc;
		int retries;
		int retries = 0;

		ret = ext4_get_inode_loc(inode, &iloc);
		if (ret)

Admin message