Commit 6246d7c9 authored Dec 02, 2020 by Bean Huo Committed by Ulf Hansson Dec 04, 2020

mmc: block: Fixup condition for CMD13 polling for RPMB requests



The CMD13 polling is needed for commands with R1B responses. In commit
a0d4c7eb ("mmc: block: Add CMD13 polling for MMC IOCTLS with R1B
response"), the intent was to introduce this for requests targeted to the
RPMB partition. However, the condition to trigger the polling loop became
wrong, leading to unnecessary polling. Let's fix the condition to avoid
this.

Fixes: a0d4c7eb ("mmc: block: Add CMD13 polling for MMC IOCTLS with R1B response")
Cc: stable@vger.kernel.org
Reported-by: Zhan Liu <zliua@micron.com>
Signed-off-by: Zhan Liu <zliua@micron.com>
Signed-off-by: Bean Huo <beanhuo@micron.com>
Link: https://lore.kernel.org/r/20201202202320.22165-1-huobean@gmail.com


Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 32a9e0c4

drivers/mmc/core/block.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -580,7 +580,7 @@ static int __mmc_blk_ioctl_cmd(struct mmc_card card, struct mmc_blk_data md,

		memcpy(&(idata->ic.response), cmd.resp, sizeof(cmd.resp));

		if (idata->rpmb \|\| (cmd.flags & MMC_RSP_R1B)) {
		if (idata->rpmb \|\| (cmd.flags & MMC_RSP_R1B) == MMC_RSP_R1B) {
		/*
		* Ensure RPMB/R1B command has completed by polling CMD13
		* "Send Status".

Admin message