Commit 623b57be authored Jul 24, 2020 by Colin Ian King Committed by David S. Miller Jul 24, 2020

sctp: remove redundant initialization of variable status



The variable status is being initialized with a value that is never read
and it is being updated later with a new value.  The initialization is
redundant and can be removed.  Also put the variable declarations into
reverse christmas tree order.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a65878d6

net/sctp/protocol.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -1367,15 +1367,15 @@ static struct pernet_operations sctp_ctrlsock_ops = {
		/* Initialize the universe into something sensible. */
		static __init int sctp_init(void)
		{
		int i;
		int status = -EINVAL;
		unsigned long goal;
		unsigned long limit;
		unsigned long nr_pages = totalram_pages();
		unsigned long limit;
		unsigned long goal;
		int max_entry_order;
		int num_entries;
		int max_share;
		int status;
		int order;
		int num_entries;
		int max_entry_order;
		int i;

		sock_skb_cb_check_size(sizeof(struct sctp_ulpevent));

Admin message