media: atmel: atmel-isc-base: allow 8 bit direct dump (62387970) · Commits · 戴 / test

In case the format that the sensor sends is 8 bit only (like GREY for example) we need to be able to bypass ISC pipeline and directly dump 8 bits. That's why the hardcoded value of 16 bpp is not correct in all cases. This change allows the output format to decide what is the correct bpp (bits per pixel) such that the result is in the proper format. Signed-off-by:

Eugen Hristev <eugen.hristev@microchip.com> Signed-off-by:

Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:

Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

drivers/media/platform/atmel/atmel-isc-base.c

+9 −9

Original line number	Diff line number	Diff line
		@@ -1026,18 +1026,10 @@ static int isc_try_validate_formats(struct isc_device *isc)
		/*
		* Configures the RLP and DMA modules, depending on the output format
		* configured for the ISC.
		* If direct_dump == true, just dump raw data 8 bits.
		* If direct_dump == true, just dump raw data 8/16 bits depending on format.
		*/
		static int isc_try_configure_rlp_dma(struct isc_device *isc, bool direct_dump)
		{
		if (direct_dump) {
		isc->try_config.rlp_cfg_mode = ISC_RLP_CFG_MODE_DAT8;
		isc->try_config.dcfg_imode = ISC_DCFG_IMODE_PACKED8;
		isc->try_config.dctrl_dview = ISC_DCTRL_DVIEW_PACKED;
		isc->try_config.bpp = 16;
		return 0;
		}

		switch (isc->try_config.fourcc) {
		case V4L2_PIX_FMT_SBGGR8:
		case V4L2_PIX_FMT_SGBRG8:
		@@ -1118,6 +1110,14 @@ static int isc_try_configure_rlp_dma(struct isc_device *isc, bool direct_dump)
		default:
		return -EINVAL;
		}

		if (direct_dump) {
		isc->try_config.rlp_cfg_mode = ISC_RLP_CFG_MODE_DAT8;
		isc->try_config.dcfg_imode = ISC_DCFG_IMODE_PACKED8;
		isc->try_config.dctrl_dview = ISC_DCTRL_DVIEW_PACKED;
		return 0;
		}

		return 0;
		}

Admin message