Commit 621f7e35 authored by Kelsey Skunberg's avatar Kelsey Skunberg Committed by Bjorn Helgaas
Browse files

PCI: Make pci_set_of_node(), etc private 

These interfaces:

  void pci_set_of_node(struct pci_dev *dev);
  void pci_release_of_node(struct pci_dev *dev);
  void pci_set_bus_of_node(struct pci_bus *bus);
  void pci_release_bus_of_node(struct pci_bus *bus);

are only used in drivers/pci/ and do not need to be seen by the rest of the
kernel.  Move them to drivers/pci/pci.h so they're private to the PCI
subsystem.

Link: https://lore.kernel.org/r/20190724233848.73327-12-skunberg.kelsey@gmail.com


Signed-off-by: default avatarKelsey Skunberg <skunberg.kelsey@gmail.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent ac6c26da

drivers/pci/pci.h

+9 −0
Original line number Diff line number Diff line
@@ -592,6 +592,10 @@ struct device_node; 
int of_pci_parse_bus_range(struct device_node *node, struct resource *res);

int of_get_pci_domain_nr(struct device_node *node);

int of_pci_get_max_link_speed(struct device_node *node);

void pci_set_of_node(struct pci_dev *dev);

void pci_release_of_node(struct pci_dev *dev);

void pci_set_bus_of_node(struct pci_bus *bus);

void pci_release_bus_of_node(struct pci_bus *bus);



#else

static inline int
@@ -611,6 +615,11 @@ of_pci_get_max_link_speed(struct device_node *node) 
{

	return -EINVAL;

}



static inline void pci_set_of_node(struct pci_dev *dev) { }

static inline void pci_release_of_node(struct pci_dev *dev) { }

static inline void pci_set_bus_of_node(struct pci_bus *bus) { }

static inline void pci_release_bus_of_node(struct pci_bus *bus) { }

#endif /* CONFIG_OF */



#if defined(CONFIG_OF_ADDRESS)

include/linux/pci.h

+0 −8
Original line number Diff line number Diff line
@@ -2259,10 +2259,6 @@ int pci_vpd_find_info_keyword(const u8 *buf, unsigned int off, 
#ifdef CONFIG_OF

struct device_node;

struct irq_domain;

void pci_set_of_node(struct pci_dev *dev);

void pci_release_of_node(struct pci_dev *dev);

void pci_set_bus_of_node(struct pci_bus *bus);

void pci_release_bus_of_node(struct pci_bus *bus);

struct irq_domain *pci_host_bridge_of_msi_domain(struct pci_bus *bus);

int pci_parse_request_of_pci_ranges(struct device *dev,

				    struct list_head *resources,
@@ -2272,10 +2268,6 @@ int pci_parse_request_of_pci_ranges(struct device *dev, 
struct device_node *pcibios_get_phb_of_node(struct pci_bus *bus);



#else	/* CONFIG_OF */

static inline void pci_set_of_node(struct pci_dev *dev) { }

static inline void pci_release_of_node(struct pci_dev *dev) { }

static inline void pci_set_bus_of_node(struct pci_bus *bus) { }

static inline void pci_release_bus_of_node(struct pci_bus *bus) { }

static inline struct irq_domain *

pci_host_bridge_of_msi_domain(struct pci_bus *bus) { return NULL; }

static inline int pci_parse_request_of_pci_ranges(struct device *dev,

CRA Git | Maintained and supported by SUSTech CRA and CCSE