Commit 620de4e1 authored Apr 29, 2008 by Duane Griffin Committed by Theodore Ts'o Apr 29, 2008

jbd2: only create debugfs and stats entries if init is successful



jbd2 debugfs and stats entries should only be created if cache initialisation
is successful.  At the moment they are being created unconditionally which
will leave them dangling if cache (and hence module) initialisation fails.

Signed-off-by: Duane Griffin <duaneg@dghda.com>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

parent 5648ba5b

fs/jbd2/journal.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -2307,10 +2307,12 @@ static int __init journal_init(void)
		BUILD_BUG_ON(sizeof(struct journal_superblock_s) != 1024);

		ret = journal_init_caches();
		if (ret != 0)
		jbd2_journal_destroy_caches();
		if (ret == 0) {
		jbd2_create_debugfs_entry();
		jbd2_create_jbd_stats_proc_entry();
		} else {
		jbd2_journal_destroy_caches();
		}
		return ret;
		}

Admin message