Commit 61fd284b authored Jun 28, 2016 by Jon Hunter Committed by Thierry Reding Jun 30, 2016

soc/tegra: pmc: Ensure mutex is always initialised



The mutex used by the PMC driver may not be initialised if early
initialisation of the driver fails. If this does happen, then it could
be possible for callers of the public PMC functions to still attempt to
acquire the mutex. Fix this by initialising the mutex as soon as
possible to ensure it will always be initialised.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

parent 718a2426

drivers/soc/tegra/pmc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1504,6 +1504,8 @@ static int __init tegra_pmc_early_init(void)
		bool invert;
		u32 value;

		mutex_init(&pmc->powergates_lock);

		np = of_find_matching_node_and_match(NULL, tegra_pmc_match, &match);
		if (!np) {
		/*
		@@ -1548,8 +1550,6 @@ static int __init tegra_pmc_early_init(void)
		return -ENXIO;
		}

		mutex_init(&pmc->powergates_lock);

		if (np) {
		pmc->soc = match->data;

Admin message