xfs: code cleanup in xfs_attr_leaf_entsize_{remote,local} (61ef5230) · Commits · 戴 / test

Cleanup the typedef usage, the unnecessary parentheses, the unnecessary backslash and use the open-coded round_up call in xfs_attr_leaf_entsize_{remote,local}. Signed-off-by:

Kaixu Xia <kaixuxia@tencent.com> Reviewed-by:

Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by:

Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by:

Christoph Hellwig <hch@lst.de>

fs/xfs/libxfs/xfs_da_format.h

+4 −4

Original line number	Diff line number	Diff line
		@@ -746,14 +746,14 @@ xfs_attr3_leaf_name_local(xfs_attr_leafblock_t *leafp, int idx)
		*/
		static inline int xfs_attr_leaf_entsize_remote(int nlen)
		{
		return ((uint)sizeof(xfs_attr_leaf_name_remote_t) - 1 + (nlen) + \
		XFS_ATTR_LEAF_NAME_ALIGN - 1) & ~(XFS_ATTR_LEAF_NAME_ALIGN - 1);
		return round_up(sizeof(struct xfs_attr_leaf_name_remote) - 1 +
		nlen, XFS_ATTR_LEAF_NAME_ALIGN);
		}

		static inline int xfs_attr_leaf_entsize_local(int nlen, int vlen)
		{
		return ((uint)sizeof(xfs_attr_leaf_name_local_t) - 1 + (nlen) + (vlen) +
		XFS_ATTR_LEAF_NAME_ALIGN - 1) & ~(XFS_ATTR_LEAF_NAME_ALIGN - 1);
		return round_up(sizeof(struct xfs_attr_leaf_name_local) - 1 +
		nlen + vlen, XFS_ATTR_LEAF_NAME_ALIGN);
		}

		static inline int xfs_attr_leaf_entsize_local_max(int bsize)

Admin message