Commit 61ea02d2 authored Sep 24, 2019 by Tariq Toukan Committed by Saeed Mahameed Oct 18, 2019

net/mlx5e: TX, Fix consumer index of error cqe dump



The completion queue consumer index increments upon a call to
mlx5_cqwq_pop().
When dumping an error CQE, the index is already incremented.
Decrease one for the print command.

Fixes: 16cc14d8 ("net/mlx5e: Dump xmit error completions")
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 46a3ea98

drivers/net/ethernet/mellanox/mlx5/core/en_tx.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -403,7 +403,10 @@ netdev_tx_t mlx5e_xmit(struct sk_buff skb, struct net_device dev)
		static void mlx5e_dump_error_cqe(struct mlx5e_txqsq *sq,
		struct mlx5_err_cqe *err_cqe)
		{
		u32 ci = mlx5_cqwq_get_ci(&sq->cq.wq);
		struct mlx5_cqwq *wq = &sq->cq.wq;
		u32 ci;

		ci = mlx5_cqwq_ctr2ix(wq, wq->cc - 1);

		netdev_err(sq->channel->netdev,
		"Error cqe on cqn 0x%x, ci 0x%x, sqn 0x%x, opcode 0x%x, syndrome 0x%x, vendor syndrome 0x%x\n",

Admin message