Commit 61e604e6 authored Oct 13, 2020 by Gustavo A. R. Silva Committed by Linus Torvalds Oct 13, 2020

mm: memcontrol: use the preferred form for passing the size of a structure type



Use the preferred form for passing the size of a structure type.  The
alternative form where the structure type is spelled out hurts readability
and introduces an opportunity for a bug when the object type is changed
but the corresponding object identifier to which the sizeof operator is
applied is not.

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
Link: https://lkml.kernel.org/r/773e013ff2f07fe2a0b47153f14dea054c0c04f1.1596214831.git.gustavoars@kernel.org


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e90342e6

mm/memcontrol.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4264,7 +4264,7 @@ static int __mem_cgroup_usage_register_event(struct mem_cgroup *memcg,
		new->entries[size - 1].threshold = threshold;

		/* Sort thresholds. Registering of new threshold isn't time-critical */
		sort(new->entries, size, sizeof(struct mem_cgroup_threshold),
		sort(new->entries, size, sizeof(*new->entries),
		compare_thresholds, NULL);

		/* Find current threshold */

Admin message