Commit 61d1cf16 authored Mar 02, 2014 by Gabor Juhos Committed by Mark Brown Mar 03, 2014

spi: spi-ath79: fix initial GPIO CS line setup



The 'ath79_spi_setup_cs' function initializes the chip
select line of a given SPI device in order to make sure
that the device is inactive.

If the SPI_CS_HIGH bit is set for a given device, it
means that the CS line of that device is active HIGH
so it must be set to LOW initially. In case of GPIO
CS lines, the 'ath79_spi_setup_cs' function does the
opposite of that due to the wrong GPIO flags.

Fix the code to use the correct GPIO flags.

Reported-by: Ronald Wahl <ronald.wahl@raritan.com>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
Cc: stable@vger.kernel.org

parent 38dbfb59

drivers/spi/spi-ath79.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -132,9 +132,9 @@ static int ath79_spi_setup_cs(struct spi_device *spi)

		flags = GPIOF_DIR_OUT;
		if (spi->mode & SPI_CS_HIGH)
		flags \|= GPIOF_INIT_HIGH;
		else
		flags \|= GPIOF_INIT_LOW;
		else
		flags \|= GPIOF_INIT_HIGH;

		status = gpio_request_one(cdata->gpio, flags,
		dev_name(&spi->dev));

Admin message