media: mantis: fix two smatch errors (61b8584a) · Commits · 戴 / test

Drop two dprintk's that relied on a non-NULL mantis pointer when it was in fact a NULL pointer. Fix those warnings: drivers/media/pci/mantis/mantis_cards.c:73 mantis_irq_handler() error: we previously assumed 'mantis' could be null (see line 72) drivers/media/pci/mantis/hopper_cards.c:64 hopper_irq_handler() error: we previously assumed 'mantis' could be null (see line 63) Signed-off-by:

Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:

Mauro Carvalho Chehab <mchehab@kernel.org>

drivers/media/pci/mantis/hopper_cards.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -60,10 +60,8 @@ static irqreturn_t hopper_irq_handler(int irq, void *dev_id)
		struct mantis_ca *ca;

		mantis = (struct mantis_pci *) dev_id;
		if (unlikely(!mantis)) {
		dprintk(MANTIS_ERROR, 1, "Mantis == NULL");
		if (unlikely(!mantis))
		return IRQ_NONE;
		}
		ca = mantis->mantis_ca;

		stat = mmread(MANTIS_INT_STAT);

drivers/media/pci/mantis/mantis_cards.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -69,10 +69,8 @@ static irqreturn_t mantis_irq_handler(int irq, void *dev_id)
		struct mantis_ca *ca;

		mantis = (struct mantis_pci *) dev_id;
		if (unlikely(mantis == NULL)) {
		dprintk(MANTIS_ERROR, 1, "Mantis == NULL");
		if (unlikely(!mantis))
		return IRQ_NONE;
		}
		ca = mantis->mantis_ca;

		stat = mmread(MANTIS_INT_STAT);

Admin message