Commit 618fd1ed authored by Ganapathi Bhat's avatar Ganapathi Bhat Committed by Kalle Valo
Browse files

mwifiex: avoid exporting mwifiex_send_cmd 



This is a follow-up patch for commit 21c5c83c
("mwifiex: support sysfs initiated device coredump").

Let us avoid exporting mwifiex_send_cmd and instead use a utility
function mwifiex_fw_dump_event to achive the work.

Signed-off-by: default avatarGanapathi Bhat <gbhat@marvell.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent a53e8f3e

drivers/net/wireless/marvell/mwifiex/cmdevt.c

+0 −1
Original line number Diff line number Diff line
@@ -674,7 +674,6 @@ int mwifiex_send_cmd(struct mwifiex_private *priv, u16 cmd_no, 


	return ret;

}

EXPORT_SYMBOL_GPL(mwifiex_send_cmd);



/*

 * This function queues a command to the command pending queue.

drivers/net/wireless/marvell/mwifiex/main.h

+1 −0
Original line number Diff line number Diff line
@@ -1691,6 +1691,7 @@ void mwifiex_drv_info_dump(struct mwifiex_adapter *adapter); 
void mwifiex_prepare_fw_dump_info(struct mwifiex_adapter *adapter);

void mwifiex_upload_device_dump(struct mwifiex_adapter *adapter);

void *mwifiex_alloc_dma_align_buf(int rx_len, gfp_t flags);

void mwifiex_fw_dump_event(struct mwifiex_private *priv);

void mwifiex_queue_main_work(struct mwifiex_adapter *adapter);

int mwifiex_get_wakeup_reason(struct mwifiex_private *priv, u16 action,

			      int cmd_type,

drivers/net/wireless/marvell/mwifiex/usb.c

+2 −3
Original line number Diff line number Diff line
@@ -658,9 +658,8 @@ static void mwifiex_usb_coredump(struct device *dev) 
	struct usb_interface *intf = to_usb_interface(dev);

	struct usb_card_rec *card = usb_get_intfdata(intf);



	mwifiex_send_cmd(mwifiex_get_priv(card->adapter, MWIFIEX_BSS_ROLE_ANY),

			 HostCmd_CMD_FW_DUMP_EVENT, HostCmd_ACT_GEN_SET, 0,

			 NULL, true);

	mwifiex_fw_dump_event(mwifiex_get_priv(card->adapter,

					       MWIFIEX_BSS_ROLE_ANY));

}



static struct usb_driver mwifiex_usb_driver = {

drivers/net/wireless/marvell/mwifiex/util.c

+7 −0
Original line number Diff line number Diff line
@@ -757,3 +757,10 @@ void *mwifiex_alloc_dma_align_buf(int rx_len, gfp_t flags) 
	return skb;

}

EXPORT_SYMBOL_GPL(mwifiex_alloc_dma_align_buf);



void mwifiex_fw_dump_event(struct mwifiex_private *priv)

{

	mwifiex_send_cmd(priv, HostCmd_CMD_FW_DUMP_EVENT, HostCmd_ACT_GEN_SET,

			 0, NULL, true);

}

EXPORT_SYMBOL_GPL(mwifiex_fw_dump_event);

CRA Git | Maintained and supported by SUSTech CRA and CCSE