Commit 618de0f4 authored Dec 18, 2020 by Takashi Iwai

ALSA: pcm: Clear the full allocated memory at hw_params

The PCM hw_params core function tries to clear up the PCM buffer
before actually using for avoiding the information leak from the
previous usages or the usage before a new allocation. It performs the
memset() with runtime->dma_bytes, but this might still leave some
remaining bytes untouched; namely, the PCM buffer size is aligned in
page size for mmap, hence runtime->dma_bytes doesn't necessarily cover
all PCM buffer pages, and the remaining bytes are exposed via mmap.

This patch changes the memory clearance to cover the all buffer pages
if the stream is supposed to be mmap-ready (that guarantees that the
buffer size is aligned in page size).

Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20201218145625.2045-3-tiwai@suse.de

Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 5c1733e3

sound/core/pcm_native.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -755,8 +755,13 @@ static int snd_pcm_hw_params(struct snd_pcm_substream *substream,
		runtime->boundary *= 2;

		/* clear the buffer for avoiding possible kernel info leaks */
		if (runtime->dma_area && !substream->ops->copy_user)
		memset(runtime->dma_area, 0, runtime->dma_bytes);
		if (runtime->dma_area && !substream->ops->copy_user) {
		size_t size = runtime->dma_bytes;

		if (runtime->info & SNDRV_PCM_INFO_MMAP)
		size = PAGE_ALIGN(size);
		memset(runtime->dma_area, 0, size);
		}

		snd_pcm_timer_resolution_change(substream);
		snd_pcm_set_state(substream, SNDRV_PCM_STATE_SETUP);

Admin message