Commit 61793af6 authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

mlxsw: pci: Remove unused bit 



The overrun ignore bit isn't supported by the device's firmware and was
recently removed from the programmer's reference manual (PRM).

Remove it from the driver as well.

Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1182e536

drivers/net/ethernet/mellanox/mlxsw/cmd.h

+0 −12
Original line number Diff line number Diff line
@@ -1043,13 +1043,6 @@ MLXSW_ITEM32(cmd_mbox, sw2hw_cq, cv, 0x00, 28, 4); 
 */

MLXSW_ITEM32(cmd_mbox, sw2hw_cq, c_eqn, 0x00, 24, 1);



/* cmd_mbox_sw2hw_cq_oi

 * When set, overrun ignore is enabled. When set, updates of

 * CQ consumer counter (poll for completion) or Request completion

 * notifications (Arm CQ) DoorBells should not be rung on that CQ.

 */

MLXSW_ITEM32(cmd_mbox, sw2hw_cq, oi, 0x00, 12, 1);



/* cmd_mbox_sw2hw_cq_st

 * Event delivery state machine

 * 0x0 - FIRED
@@ -1132,11 +1125,6 @@ static inline int mlxsw_cmd_sw2hw_eq(struct mlxsw_core *mlxsw_core, 
 */

MLXSW_ITEM32(cmd_mbox, sw2hw_eq, int_msix, 0x00, 24, 1);



/* cmd_mbox_sw2hw_eq_oi

 * When set, overrun ignore is enabled.

 */

MLXSW_ITEM32(cmd_mbox, sw2hw_eq, oi, 0x00, 12, 1);



/* cmd_mbox_sw2hw_eq_st

 * Event delivery state machine

 * 0x0 - FIRED

drivers/net/ethernet/mellanox/mlxsw/pci.c

+0 −2
Original line number Diff line number Diff line
@@ -580,7 +580,6 @@ static int mlxsw_pci_cq_init(struct mlxsw_pci *mlxsw_pci, char *mbox, 


	mlxsw_cmd_mbox_sw2hw_cq_cv_set(mbox, 0); /* CQE ver 0 */

	mlxsw_cmd_mbox_sw2hw_cq_c_eqn_set(mbox, MLXSW_PCI_EQ_COMP_NUM);

	mlxsw_cmd_mbox_sw2hw_cq_oi_set(mbox, 0);

	mlxsw_cmd_mbox_sw2hw_cq_st_set(mbox, 0);

	mlxsw_cmd_mbox_sw2hw_cq_log_cq_size_set(mbox, ilog2(q->count));

	for (i = 0; i < MLXSW_PCI_AQ_PAGES; i++) {
@@ -755,7 +754,6 @@ static int mlxsw_pci_eq_init(struct mlxsw_pci *mlxsw_pci, char *mbox, 
	}



	mlxsw_cmd_mbox_sw2hw_eq_int_msix_set(mbox, 1); /* MSI-X used */

	mlxsw_cmd_mbox_sw2hw_eq_oi_set(mbox, 0);

	mlxsw_cmd_mbox_sw2hw_eq_st_set(mbox, 1); /* armed */

	mlxsw_cmd_mbox_sw2hw_eq_log_eq_size_set(mbox, ilog2(q->count));

	for (i = 0; i < MLXSW_PCI_AQ_PAGES; i++) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE