Commit 616c3196 authored Nov 25, 2015 by Jeff Layton Committed by Trond Myklebust Nov 25, 2015

nfs: ensure that attrcache is revalidated after a SETATTR



If we get no post-op attributes back from a SETATTR operation, then no
attributes will of course be updated during the call to
nfs_update_inode.

We know however that the attributes are invalid at that point, since we
just changed some of them. At the very least, the ctime will be bogus.
If we get no post-op attributes back on the call, mark the attrcache
invalid to reflect that fact.

Reviewed-by: Steve French <steve.french@primarydata.com>
Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent 38b7631f

fs/nfs/inode.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -618,7 +618,10 @@ void nfs_setattr_update_inode(struct inode inode, struct iattr attr,
		nfs_inc_stats(inode, NFSIOS_SETATTRTRUNC);
		nfs_vmtruncate(inode, attr->ia_size);
		}
		if (fattr->valid)
		nfs_update_inode(inode, fattr);
		else
		NFS_I(inode)->cache_validity \|= NFS_INO_INVALID_ATTR;
		spin_unlock(&inode->i_lock);
		}
		EXPORT_SYMBOL_GPL(nfs_setattr_update_inode);

Admin message