Commit 6167a5b4 authored by Kamenee Arumugam's avatar Kamenee Arumugam Committed by Doug Ledford
Browse files

IB/qib: Stricter bounds checking for copy to buffer 



Replace 'strcpy' with 'strncpy' to restrict the number
of bytes copied to the buffer.

Reviewed-by: default avatarMichael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: default avatarKamenee Arumugam <kamenee.arumugam@intel.com>
Signed-off-by: default avatarDennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 34ab4de7

drivers/infiniband/hw/qib/qib_iba7322.c

+2 −2
Original line number Diff line number Diff line
@@ -6175,7 +6175,7 @@ static int setup_txselect(const char *str, struct kernel_param *kp) 
	unsigned long val;

	char *n;



	if (strlen(str) >= MAX_ATTEN_LEN) {

	if (strlen(str) >= ARRAY_SIZE(txselect_list)) {

		pr_info("txselect_values string too long\n");

		return -ENOSPC;

	}
@@ -6186,7 +6186,7 @@ static int setup_txselect(const char *str, struct kernel_param *kp) 
			TXDDS_TABLE_SZ + TXDDS_EXTRA_SZ + TXDDS_MFG_SZ);

		return -EINVAL;

	}

	strcpy(txselect_list, str);

	strncpy(txselect_list, str, ARRAY_SIZE(txselect_list) - 1);



	list_for_each_entry(dd, &qib_dev_list, list)

		if (dd->deviceid == PCI_DEVICE_ID_QLOGIC_IB_7322)

CRA Git | Maintained and supported by SUSTech CRA and CCSE