Commit 6159e963 authored Oct 11, 2020 by Julia Lawall Committed by Jakub Kicinski Oct 13, 2020

net/ipv6: use semicolons rather than commas to separate statements

Replace commas with semicolons.  Commas introduce unnecessary
variability in the code structure and are hard to see.  What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/

):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Acked-by: Paul Moore <paul@paul-moore.com>
Link: https://lore.kernel.org/r/1602412498-32025-5-git-send-email-Julia.Lawall@inria.fr


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 44797589

net/ipv6/calipso.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -761,7 +761,7 @@ static int calipso_genopt(unsigned char *buf, u32 start, u32 buf_len,
		calipso[1] = len - 2;
		(__be32 )(calipso + 2) = htonl(doi_def->doi);
		calipso[6] = (len - CALIPSO_HDR_LEN) / 4;
		calipso[7] = secattr->attr.mls.lvl,
		calipso[7] = secattr->attr.mls.lvl;
		crc = ~crc_ccitt(0xffff, calipso, len);
		calipso[8] = crc & 0xff;
		calipso[9] = (crc >> 8) & 0xff;

Admin message