Commit 615457a2 authored Nov 01, 2019 by Colin Ian King Committed by Jeff Kirsher Nov 08, 2019

ice: fix potential infinite loop because loop counter being too small



Currently the for-loop counter i is a u8 however it is being checked
against a maximum value hw->num_tx_sched_layers which is a u16. Hence
there is a potential wrap-around of counter i back to zero if
hw->num_tx_sched_layers is greater than 255.  Fix this by making i
a u16.

Addresses-Coverity: ("Infinite loop")
Fixes: b36c598c ("ice: Updates to Tx scheduler code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 1b53d644

drivers/net/ethernet/intel/ice/ice_sched.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1036,7 +1036,7 @@ enum ice_status ice_sched_query_res_alloc(struct ice_hw *hw)
		struct ice_aqc_query_txsched_res_resp *buf;
		enum ice_status status = 0;
		__le16 max_sibl;
		u8 i;
		u16 i;

		if (hw->layer_info)
		return status;

Admin message