libata: Spot bridge chips (614fe29b) · Commits · 戴 / test

If we have a PATA cable with a SATA drive on it then we've found a bridge and we can flip the cable type. This fixes some cable detect problems with SATA bridges on chipsets and misdetected cable types. In theory cable detection and mode limiting is needed if you put a SATA/PATA bridge on a 40 wire cable, but I see no way to deal with that other than to point out its not a good idea anyway. Signed-off-by:

Alan Cox <alan@redhat.com> Signed-off-by:

Jeff Garzik <jeff@garzik.org>

drivers/ata/libata-core.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -2183,6 +2183,17 @@ int ata_bus_probe(struct ata_port *ap)
		if (ap->ops->cable_detect)
		ap->cbl = ap->ops->cable_detect(ap);

		/* We may have SATA bridge glue hiding here irrespective of the
		reported cable types and sensed types */
		ata_link_for_each_dev(dev, &ap->link) {
		if (!ata_dev_enabled(dev))
		continue;
		/* SATA drives indicate we have a bridge. We don't know which
		end of the link the bridge is which is a problem */
		if (ata_id_is_sata(dev->id))
		ap->cbl = ATA_CBL_SATA;
		}

		/* After the identify sequence we can now set up the devices. We do
		this in the normal order so that the user doesn't get confused */

Admin message