Commit 6146fde3 authored Jan 22, 2018 by Hugues Fruchet Committed by Mauro Carvalho Chehab Jan 23, 2018

media: ov5640: fix spurious streamon failures

Time to time, stream on is failing with a strange positive error.
Error code is returned erroneously by ov5640_set_ctrl_exposure()
due to ov5640_get_vts() return value wrongly treated as error.
Fix this by forcing ret to 0 after ov5640_get_vts() success call,
in order that ret is set to success for rest of code sequence.

Signed-off-by: Hugues Fruchet <hugues.fruchet@st.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 401f6930

drivers/media/i2c/ov5640.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2057,6 +2057,7 @@ static int ov5640_set_ctrl_exposure(struct ov5640_dev *sensor, int exp)
		if (ret < 0)
		return ret;
		max_exp += ret;
		ret = 0;

		if (ctrls->exposure->val < max_exp)
		ret = ov5640_set_exposure(sensor, ctrls->exposure->val);

Admin message