configfs: call fsnotify_rmdir() hook (6146e78c) · Commits · 戴 / test

This will allow generating fsnotify delete events on unregister of group/subsystem after the fsnotify_nameremove() hook is removed from d_delete(). The rest of the d_delete() calls from this filesystem are either called recursively from within debugfs_unregister_{group,subsystem}, called from a vfs function that already has delete hooks or are called from shutdown/cleanup code. Cc: Joel Becker <jlbec@evilplan.org> Cc: Christoph Hellwig <hch@lst.de> Signed-off-by:

Amir Goldstein <amir73il@gmail.com> Signed-off-by:

Jan Kara <jack@suse.cz>

fs/configfs/dir.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -27,6 +27,7 @@
		#undef DEBUG

		#include <linux/fs.h>
		#include <linux/fsnotify.h>
		#include <linux/mount.h>
		#include <linux/module.h>
		#include <linux/slab.h>
		@@ -1804,6 +1805,7 @@ void configfs_unregister_group(struct config_group *group)
		configfs_detach_group(&group->cg_item);
		d_inode(dentry)->i_flags \|= S_DEAD;
		dont_mount(dentry);
		fsnotify_rmdir(d_inode(parent), dentry);
		d_delete(dentry);
		inode_unlock(d_inode(parent));

		@@ -1932,6 +1934,7 @@ void configfs_unregister_subsystem(struct configfs_subsystem *subsys)
		configfs_detach_group(&group->cg_item);
		d_inode(dentry)->i_flags \|= S_DEAD;
		dont_mount(dentry);
		fsnotify_rmdir(d_inode(root), dentry);
		inode_unlock(d_inode(dentry));

		d_delete(dentry);

Admin message