Commit 61139eb0 authored Oct 20, 2014 by Ard Biesheuvel

arm64/efi: invert UEFI memory region reservation logic



Instead of reserving the memory regions based on which types we know
need to be reserved, consider only regions of the following types as
free for general use by the OS:

EFI_LOADER_CODE
EFI_LOADER_DATA
EFI_BOOT_SERVICES_CODE
EFI_BOOT_SERVICES_DATA
EFI_CONVENTIONAL_MEMORY

Note that this also fixes a problem with the original code, which would
misidentify a EFI_RUNTIME_SERVICES_DATA region as not reserved if it
does not have the EFI_MEMORY_RUNTIME attribute set. However, it is
perfectly legal for the firmware not to request a virtual mapping for
EFI_RUNTIME_SERVICES_DATA regions that contain configuration tables, in
which case the EFI_MEMORY_RUNTIME attribute would not be set.

Acked-by: Roy Franz <roy.franz@linaro.org>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

parent a352ea3e

arch/arm64/kernel/efi.c

+10 −10

Original line number	Diff line number	Diff line
		@@ -125,17 +125,17 @@ out:
		*/
		static __init int is_reserve_region(efi_memory_desc_t *md)
		{
		if (!is_normal_ram(md))
		return 0;

		if (md->attribute & EFI_MEMORY_RUNTIME)
		return 1;

		if (md->type == EFI_ACPI_RECLAIM_MEMORY \|\|
		md->type == EFI_RESERVED_TYPE)
		return 1;

		switch (md->type) {
		case EFI_LOADER_CODE:
		case EFI_LOADER_DATA:
		case EFI_BOOT_SERVICES_CODE:
		case EFI_BOOT_SERVICES_DATA:
		case EFI_CONVENTIONAL_MEMORY:
		return 0;
		default:
		break;
		}
		return is_normal_ram(md);
		}

		static __init void reserve_regions(void)

Admin message