Commit 61135e96 authored Sep 11, 2013 by Joe Perches Committed by Linus Torvalds Sep 11, 2013

checkpatch: fix networking kernel-doc block comment defect



checkpatch can generate a false positive when inserting a new kernel-doc
block and function above an existing kernel-doc block.

Fix it by checking that the context line is also a newly inserted line.

Signed-off-by: Joe Perches <joe@perches.com>
Reported-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 70dc8a48

scripts/checkpatch.pl

+1 −0

Original line number	Diff line number	Diff line
		@@ -2086,6 +2086,7 @@ sub process {
		if ($realfile =~ m@^(drivers/net/\|net/)@ &&
		$prevrawline =~ /^\+[ \t]\/\/ && #starting /*
		$prevrawline !~ /\\/[ \t]$/ && #no trailing */
		$rawline =~ /^\+/ && #line is new
		$rawline !~ /^\+[ \t]\/) { #no leading *
		WARN("NETWORKING_BLOCK_COMMENT_STYLE",
		"networking block comments start with * on subsequent lines\n" . $hereprev);

Admin message