Commit 6112ef62 authored Jul 05, 2020 by Kamal Heib Committed by Jason Gunthorpe Jul 16, 2020

RDMA/rxe: Drop pointless checks in rxe_init_ports

Both pkey_tbl_len and gid_tbl_len are set in rxe_init_port_param() - so no
need to check if they aren't set.

Fixes: 8700e3e7 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/20200705104313.283034-2-kamalheib1@gmail.com


Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

parent cbeb7d89

drivers/infiniband/sw/rxe/rxe.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -147,9 +147,6 @@ static int rxe_init_ports(struct rxe_dev *rxe)

		rxe_init_port_param(port);

		if (!port->attr.pkey_tbl_len \|\| !port->attr.gid_tbl_len)
		return -EINVAL;

		port->pkey_tbl = kcalloc(port->attr.pkey_tbl_len,
		sizeof(*port->pkey_tbl), GFP_KERNEL);

Admin message