Commit 610986e7 authored Apr 30, 2015 by Alexander Duyck Committed by David S. Miller May 03, 2015

etherdev: Use skb->data to retrieve Ethernet header instead of eth_hdr



Avoid recomputing the Ethernet header location and instead just use the
pointer provided by skb->data.  The problem with using eth_hdr is that the
compiler wasn't smart enough to realize that skb->head + skb->mac_header
was the same thing as skb->data before it added ETH_HLEN.  By just caching
it off before calling skb_pull_inline we can avoid a few unnecessary
instructions.

Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d54385ce

net/ethernet/eth.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -156,8 +156,9 @@ __be16 eth_type_trans(struct sk_buff skb, struct net_device dev)

		skb->dev = dev;
		skb_reset_mac_header(skb);

		eth = (struct ethhdr *)skb->data;
		skb_pull_inline(skb, ETH_HLEN);
		eth = eth_hdr(skb);

		if (unlikely(is_multicast_ether_addr_64bits(eth->h_dest))) {
		if (ether_addr_equal_64bits(eth->h_dest, dev->broadcast))

Admin message