Commit 61014e96 authored by Vivek Goyal's avatar Vivek Goyal Committed by Jens Axboe
Browse files

blkio: deletion of a cgroup was causes oops 



o Now a cgroup list of blkg elements can contain blkg from multiple policies.
  Before sending an unlink event, make sure blkg belongs to they policy. If
  policy does not own the blkg, do not send update for this blkg.

Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
Signed-off-by: default avatarJens Axboe <jaxboe@fusionio.com>
parent 13f98250

block/blk-cgroup.c

+5 −4
Original line number Original line Diff line number Diff line
@@ -1411,13 +1411,14 @@ static void blkiocg_destroy(struct cgroup_subsys *subsys, struct cgroup *cgroup) 
		/*

		/*

		 * This blkio_group is being unlinked as associated cgroup is

		 * This blkio_group is being unlinked as associated cgroup is

		 * going away. Let all the IO controlling policies know about

		 * going away. Let all the IO controlling policies know about

		 * this event. Currently this is static call to one io

		 * this event.

		 * controlling policy. Once we have more policies in place, we

		 * need some dynamic registration of callback function.

		 */

		 */

		spin_lock(&blkio_list_lock);

		spin_lock(&blkio_list_lock);

		list_for_each_entry(blkiop, &blkio_list, list)

		list_for_each_entry(blkiop, &blkio_list, list) {

			if (blkiop->plid != blkg->plid)

				continue;

			blkiop->ops.blkio_unlink_group_fn(key, blkg);

			blkiop->ops.blkio_unlink_group_fn(key, blkg);

		}

		spin_unlock(&blkio_list_lock);

		spin_unlock(&blkio_list_lock);

	} while (1);

	} while (1);

CRA Git | Maintained and supported by SUSTech CRA and CCSE