Commit 60f7691c authored Mar 02, 2019 by Louis Taylor Committed by Wolfram Sang Mar 12, 2019

i2c: sis630: correct format strings

When compiling with -Wformat, clang warns:

drivers/i2c/busses/i2c-sis630.c:482:4: warning: format specifies type
      'unsigned short' but the argument has type 'int' [-Wformat]
                        smbus_base + SMB_STS,
                        ^~~~~~~~~~~~~~~~~~~~

drivers/i2c/busses/i2c-sis630.c:483:4: warning: format specifies type
      'unsigned short' but the argument has type 'int' [-Wformat]
                        smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1);
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

drivers/i2c/busses/i2c-sis630.c:531:37: warning: format specifies type
      'unsigned short' but the argument has type 'int' [-Wformat]
                 "SMBus SIS630 adapter at %04hx", smbus_base + SMB_STS);
                                          ~~~~~   ^~~~~~~~~~~~~~~~~~~~

This patch fixes the format strings to use the format type for int.

Link: https://github.com/ClangBuiltLinux/linux/issues/378


Signed-off-by: Louis Taylor <louis@kragniz.eu>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent bc1a7f75

drivers/i2c/busses/i2c-sis630.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -478,7 +478,7 @@ static int sis630_setup(struct pci_dev *sis630_dev)
		if (!request_region(smbus_base + SMB_STS, SIS630_SMB_IOREGION,
		sis630_driver.name)) {
		dev_err(&sis630_dev->dev,
		"I/O Region 0x%04hx-0x%04hx for SMBus already in use.\n",
		"I/O Region 0x%04x-0x%04x for SMBus already in use.\n",
		smbus_base + SMB_STS,
		smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1);
		retval = -EBUSY;
		@@ -528,7 +528,7 @@ static int sis630_probe(struct pci_dev dev, const struct pci_device_id id)
		sis630_adapter.dev.parent = &dev->dev;

		snprintf(sis630_adapter.name, sizeof(sis630_adapter.name),
		"SMBus SIS630 adapter at %04hx", smbus_base + SMB_STS);
		"SMBus SIS630 adapter at %04x", smbus_base + SMB_STS);

		return i2c_add_adapter(&sis630_adapter);
		}

Admin message