Commit 60f22086 authored May 05, 2019 by Ruslan Babayev Committed by Jonathan Cameron May 11, 2019

iio: dac: ds4422/ds4424 fix chip verification

The ds4424_get_value function takes channel number as it's 3rd
argument and translates it internally into I2C address using
DS4424_DAC_ADDR macro. The caller ds4424_verify_chip was passing an
already translated I2C address as its last argument.

Signed-off-by: Ruslan Babayev <ruslan@babayev.com>
Cc: xe-linux-external@cisco.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

parent 1615fe41

drivers/iio/dac/ds4424.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -166,7 +166,7 @@ static int ds4424_verify_chip(struct iio_dev *indio_dev)
		{
		int ret, val;

		ret = ds4424_get_value(indio_dev, &val, DS4424_DAC_ADDR(0));
		ret = ds4424_get_value(indio_dev, &val, 0);
		if (ret < 0)
		dev_err(&indio_dev->dev,
		"%s failed. ret: %d\n", __func__, ret);

Admin message