Commit 60e2dde1 authored Aug 19, 2019 by Wenwen Wang Committed by Jacek Anaszewski Aug 20, 2019

led: triggers: Fix a memory leak bug



In led_trigger_set(), 'event' is allocated in kasprintf(). However, it is
not deallocated in the following execution if the label 'err_activate' or
'err_add_groups' is entered, leading to memory leaks. To fix this issue,
free 'event' before returning the error.

Fixes: 52c47742 ("leds: triggers: send uevent when changing triggers")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>

parent 3881a72f

drivers/leds/led-triggers.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -173,6 +173,7 @@ err_activate:
		list_del(&led_cdev->trig_list);
		write_unlock_irqrestore(&led_cdev->trigger->leddev_list_lock, flags);
		led_set_brightness(led_cdev, LED_OFF);
		kfree(event);

		return ret;
		}

Admin message