Commit 60c958d8 authored by Guilherme G. Piccoli's avatar Guilherme G. Piccoli Committed by Linus Torvalds
Browse files

panic: add sysctl to dump all CPUs backtraces on oops event 



Usually when the kernel reaches an oops condition, it's a point of no
return; in case not enough debug information is available in the kernel
splat, one of the last resorts would be to collect a kernel crash dump
and analyze it.  The problem with this approach is that in order to
collect the dump, a panic is required (to kexec-load the crash kernel).
When in an environment of multiple virtual machines, users may prefer to
try living with the oops, at least until being able to properly shutdown
their VMs / finish their important tasks.

This patch implements a way to collect a bit more debug details when an
oops event is reached, by printing all the CPUs backtraces through the
usage of NMIs (on architectures that support that).  The sysctl added
(and documented) here was called "oops_all_cpu_backtrace", and when set
will (as the name suggests) dump all CPUs backtraces.

Far from ideal, this may be the last option though for users that for
some reason cannot panic on oops.  Most of times oopses are clear enough
to indicate the kernel portion that must be investigated, but in virtual
environments it's possible to observe hypervisor/KVM issues that could
lead to oopses shown in other guests CPUs (like virtual APIC crashes).
This patch hence aims to help debug such complex issues without
resorting to kdump.

Signed-off-by: default avatarGuilherme G. Piccoli <gpiccoli@canonical.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Iurii Zaikin <yzaikin@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Randy Dunlap <rdunlap@infradead.org>
Cc: Matthew Wilcox <willy@infradead.org>
Link: http://lkml.kernel.org/r/20200327224116.21030-1-gpiccoli@canonical.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0ec9dc9b

Documentation/admin-guide/sysctl/kernel.rst

+16 −0
Original line number Diff line number Diff line
@@ -646,6 +646,22 @@ rate for each task. 
scanned for a given scan.





oops_all_cpu_backtrace:

================



If this option is set, the kernel will send an NMI to all CPUs to dump

their backtraces when an oops event occurs. It should be used as a last

resort in case a panic cannot be triggered (to protect VMs running, for

example) or kdump can't be collected. This file shows up if CONFIG_SMP

is enabled.



0: Won't show all CPUs backtraces when an oops is detected.

This is the default behavior.



1: Will non-maskably interrupt all CPUs and dump their backtraces when

an oops event is detected.





osrelease, ostype & version

===========================

include/linux/kernel.h

+6 −0
Original line number Diff line number Diff line
@@ -520,6 +520,12 @@ static inline u32 int_sqrt64(u64 x) 
}

#endif



#ifdef CONFIG_SMP

extern unsigned int sysctl_oops_all_cpu_backtrace;

#else

#define sysctl_oops_all_cpu_backtrace 0

#endif /* CONFIG_SMP */



extern void bust_spinlocks(int yes);

extern int oops_in_progress;		/* If set, an oops, panic(), BUG() or die() is in progress */

extern int panic_timeout;

kernel/panic.c

+11 −0
Original line number Diff line number Diff line
@@ -36,6 +36,14 @@ 
#define PANIC_TIMER_STEP 100

#define PANIC_BLINK_SPD 18



#ifdef CONFIG_SMP

/*

 * Should we dump all CPUs backtraces in an oops event?

 * Defaults to 0, can be changed via sysctl.

 */

unsigned int __read_mostly sysctl_oops_all_cpu_backtrace;

#endif /* CONFIG_SMP */



int panic_on_oops = CONFIG_PANIC_ON_OOPS_VALUE;

static unsigned long tainted_mask =

	IS_ENABLED(CONFIG_GCC_PLUGIN_RANDSTRUCT) ? (1 << TAINT_RANDSTRUCT) : 0;
@@ -522,6 +530,9 @@ void oops_enter(void) 
	/* can't trust the integrity of the kernel anymore: */

	debug_locks_off();

	do_oops_enter_exit();



	if (sysctl_oops_all_cpu_backtrace)

		trigger_all_cpu_backtrace();

}



/*

kernel/sysctl.c

+11 −0
Original line number Diff line number Diff line
@@ -2150,6 +2150,17 @@ static struct ctl_table kern_table[] = { 
		.proc_handler	= proc_dointvec,

	},

#endif

#ifdef CONFIG_SMP

	{

		.procname	= "oops_all_cpu_backtrace",

		.data		= &sysctl_oops_all_cpu_backtrace,

		.maxlen		= sizeof(int),

		.mode		= 0644,

		.proc_handler	= proc_dointvec_minmax,

		.extra1		= SYSCTL_ZERO,

		.extra2		= SYSCTL_ONE,

	},

#endif /* CONFIG_SMP */

	{

		.procname	= "pid_max",

		.data		= &pid_max,

CRA Git | Maintained and supported by SUSTech CRA and CCSE