Commit 60c1d560 authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang
Browse files

i2c: gpio: merge two very similar comments 



I think it is clear enough if we have the explanation once and make it
clear it is applicable for both SCL and SDA. Reword it a little with
the help of Simon's native language skills :)

Signed-off-by: default avatarSimon Horman <horms+renesas@verge.net.au>
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent 8fbd9b08

drivers/i2c/busses/i2c-gpio.c

+5 −12
Original line number Diff line number Diff line
@@ -286,11 +286,11 @@ static int i2c_gpio_probe(struct platform_device *pdev) 


	/*

	 * First get the GPIO pins; if it fails, we'll defer the probe.

	 * If the SDA line is marked from platform data or device tree as

	 * "open drain" it means something outside of our control is making

	 * this line being handled as open drain, and we should just handle

	 * it as any other output. Else we enforce open drain as this is

	 * required for an I2C bus.

	 * If the SCL/SDA lines are marked "open drain" by platform data or

	 * device tree then this means that something outside of our control is

	 * marking these lines to be handled as open drain, and we should just

	 * handle them as we handle any other output. Else we enforce open

	 * drain as this is required for an I2C bus.

	 */

	if (pdata->sda_is_open_drain)

		gflags = GPIOD_OUT_HIGH;
@@ -300,13 +300,6 @@ static int i2c_gpio_probe(struct platform_device *pdev) 
	if (IS_ERR(priv->sda))

		return PTR_ERR(priv->sda);



	/*

	 * If the SCL line is marked from platform data or device tree as

	 * "open drain" it means something outside of our control is making

	 * this line being handled as open drain, and we should just handle

	 * it as any other output. Else we enforce open drain as this is

	 * required for an I2C bus.

	 */

	if (pdata->scl_is_open_drain)

		gflags = GPIOD_OUT_HIGH;

	else

CRA Git | Maintained and supported by SUSTech CRA and CCSE