Commit 60af8803 authored Dec 17, 2007 by Eric Dumazet Committed by Linus Torvalds Dec 17, 2007

parport: "dev->timeslice" is an unsigned long, not an int



While auditing proc_doulongvec_ms_jiffies_minmax() usage in kernel, I found
a bug in drivers/parport/procfs.c, incorrectly using sizeof(int) instead of
sizeof(unsigned long)

Only 64bit arches are affected by this old bug.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 8d431dbe

drivers/parport/procfs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -384,7 +384,7 @@ parport_device_sysctl_template = {
		{
		.procname = "timeslice",
		.data = NULL,
		.maxlen = sizeof(int),
		.maxlen = sizeof(unsigned long),
		.mode = 0644,
		.proc_handler = &proc_doulongvec_ms_jiffies_minmax,
		.extra1 = (void*) &parport_min_timeslice_value,

Admin message