Commit 60a6e523 authored by Roman Kiryanov's avatar Roman Kiryanov Committed by Greg Kroah-Hartman
Browse files

platform: goldfish: pipe: Call misc_deregister if init fails 



Undo effects of misc_register if driver's init fails after
misc_register.

Signed-off-by: default avatarRoman Kiryanov <rkir@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 08360e26

drivers/platform/goldfish/goldfish_pipe.c

+4 −1
Original line number Diff line number Diff line
@@ -844,8 +844,10 @@ static int goldfish_pipe_device_init(struct platform_device *pdev, 
	dev->pipes_capacity = INITIAL_PIPES_CAPACITY;

	dev->pipes = kcalloc(dev->pipes_capacity, sizeof(*dev->pipes),

			     GFP_KERNEL);

	if (!dev->pipes)

	if (!dev->pipes) {

		misc_deregister(&dev->miscdev);

		return -ENOMEM;

	}



	/*

	 * We're going to pass two buffers, open_command_params and
@@ -858,6 +860,7 @@ static int goldfish_pipe_device_init(struct platform_device *pdev, 
		__get_free_page(GFP_KERNEL);

	if (!dev->buffers) {

		kfree(dev->pipes);

		misc_deregister(&dev->miscdev);

		return -ENOMEM;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE