Commit 60a27b90 authored Apr 26, 2019 by Ming Lei Committed by Jens Axboe May 01, 2019

block: fix handling for BIO_NO_PAGE_REF



Commit 399254aa ("block: add BIO_NO_PAGE_REF flag") introduces
BIO_NO_PAGE_REF, and once this flag is set for one bio, all pages
in the bio won't be get/put during IO.

However, if one bio is submitted via __blkdev_direct_IO_simple(),
even though BIO_NO_PAGE_REF is set, pages still may be put.

Fixes this issue by avoiding to put pages if BIO_NO_PAGE_REF is
set.

Fixes: 399254aa ("block: add BIO_NO_PAGE_REF flag")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 817869d2

fs/block_dev.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -264,6 +264,7 @@ __blkdev_direct_IO_simple(struct kiocb iocb, struct iov_iter iter,
		bio_for_each_segment_all(bvec, &bio, i, iter_all) {
		if (should_dirty && !PageCompound(bvec->bv_page))
		set_page_dirty_lock(bvec->bv_page);
		if (!bio_flagged(&bio, BIO_NO_PAGE_REF))
		put_page(bvec->bv_page);
		}

Admin message