Commit 60a0d233 authored Nov 14, 2007 by Johannes Berg Committed by Linus Torvalds Nov 14, 2007

hibernate: fix lockdep report



Lockdep reports a circular locking dependency in the hibernate code
because
 - during system boot hibernate code (from an initcall) locks pm_mutex
   and then a sysfs buffer mutex via name_to_dev_t
 - during regular operation hibernate code locks pm_mutex under a
   sysfs buffer mutex because it's called from sysfs methods.

The deadlock can never happen because during initcall invocation nothing
can write to sysfs yet. This removes the lockdep report by marking the
initcall locking as being in a different class.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Alan Stern <stern@rowland.harvard.edu>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent c642b839

kernel/power/disk.c

+11 −1

Original line number	Diff line number	Diff line
		@@ -456,7 +456,17 @@ static int software_resume(void)
		int error;
		unsigned int flags;

		mutex_lock(&pm_mutex);
		/*
		* name_to_dev_t() below takes a sysfs buffer mutex when sysfs
		* is configured into the kernel. Since the regular hibernate
		* trigger path is via sysfs which takes a buffer mutex before
		* calling hibernate functions (which take pm_mutex) this can
		* cause lockdep to complain about a possible ABBA deadlock
		* which cannot happen since we're in the boot code here and
		* sysfs can't be invoked yet. Therefore, we use a subclass
		* here to avoid lockdep complaining.
		*/
		mutex_lock_nested(&pm_mutex, SINGLE_DEPTH_NESTING);
		if (!swsusp_resume_device) {
		if (!strlen(resume_file)) {
		mutex_unlock(&pm_mutex);

Admin message