Commit 60977fcc authored Mar 25, 2014 by Steve French

Return correct error on query of xattr on file with empty xattrs



xfstest 020 detected a problem with cifs xattr handling.  When a file
had an empty xattr list, we returned success (with an empty xattr value)
on query of particular xattrs rather than returning ENODATA.
This patch fixes it so that query of an xattr returns ENODATA when the
xattr list is empty for the file.

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>

parent c11f1df5

fs/cifs/cifssmb.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -6197,6 +6197,9 @@ QAllEAsRetry:
		cifs_dbg(FYI, "ea length %d\n", list_len);
		if (list_len <= 8) {
		cifs_dbg(FYI, "empty EA list returned from server\n");
		/* didn't find the named attribute */
		if (ea_name)
		rc = -ENODATA;
		goto QAllEAsOut;
		}

Admin message