Commit 6083096d authored Oct 12, 2015 by Julia Lawall Committed by Andy Gross Oct 14, 2015

soc: qcom: smd: delete unneeded of_node_put

Device node iterators perform an of_node_put on each iteration, so putting
an of_node_put before a continue results in a double put.

A simplified version of the semantic match that finds this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator i;
@@

 i(..., child, ...) {
   ... when != of_node_get(child)
*  of_node_put(child);
   ...
*  continue;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Andy Gross <agross@codeaurora.org>

parent 33e38b4f

drivers/soc/qcom/smd.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -921,10 +921,8 @@ static struct device_node qcom_smd_match_channel(struct device_node edge_node,
		for_each_available_child_of_node(edge_node, child) {
		key = "qcom,smd-channels";
		ret = of_property_read_string(child, key, &name);
		if (ret) {
		of_node_put(child);
		if (ret)
		continue;
		}

		if (strcmp(name, channel) == 0)
		return child;

Admin message