Commit 6079a463 authored May 27, 2008 by Wei Yongjun Committed by David S. Miller May 27, 2008

dccp: Fix to handle short sequence numbers packet correctly



RFC4340 said:
  8.5.  Pseudocode
       ...
       If P.type is not Data, Ack, or DataAck and P.X == 0 (the packet
             has short sequence numbers), drop packet and return

But DCCP has some mistake to handle short sequence numbers packet, now
it drop packet only if P.type is Data, Ack, or DataAck and P.X == 0.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Acked-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 289c79a4

net/dccp/ipv4.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -739,8 +739,8 @@ int dccp_invalid_packet(struct sk_buff *skb)
		* If P.type is not Data, Ack, or DataAck and P.X == 0 (the packet
		* has short sequence numbers), drop packet and return
		*/
		if (dh->dccph_type >= DCCP_PKT_DATA &&
		dh->dccph_type <= DCCP_PKT_DATAACK && dh->dccph_x == 0) {
		if ((dh->dccph_type < DCCP_PKT_DATA \|\|
		dh->dccph_type > DCCP_PKT_DATAACK) && dh->dccph_x == 0) {
		DCCP_WARN("P.type (%s) not Data \|\| [Data]Ack, while P.X == 0\n",
		dccp_packet_name(dh->dccph_type));
		return 1;

Admin message