Commit 607076a9 authored Feb 10, 2019 by Lubomir Rintel Committed by Kalle Valo Feb 19, 2019

libertas_tf: don't set URB_ZERO_PACKET on IN USB transfer



It doesn't make sense and the USB core warns on each submit of such
URB, easily flooding the message buffer with tracebacks.

Analogous issue was fixed in regular libertas driver in commit 6528d880
("libertas: don't set URB_ZERO_PACKET on IN USB transfer").

Cc: stable@vger.kernel.org
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 744972b2

drivers/net/wireless/marvell/libertas_tf/if_usb.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -433,8 +433,6 @@ static int __if_usb_submit_rx_urb(struct if_usb_card *cardp,
		skb_tail_pointer(skb),
		MRVDRV_ETH_RX_PACKET_BUFFER_SIZE, callbackfn, cardp);

		cardp->rx_urb->transfer_flags \|= URB_ZERO_PACKET;

		lbtf_deb_usb2(&cardp->udev->dev, "Pointer for rx_urb %p\n",
		cardp->rx_urb);
		ret = usb_submit_urb(cardp->rx_urb, GFP_ATOMIC);

Admin message