Commit 606ddf1f authored Nov 10, 2020 by Andrew Lunn Committed by Jakub Kicinski Nov 12, 2020

drivers: net: smc91x: Fix missing kerneldoc reported by W=1

drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio'
drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio'
drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'name' not described in 'try_toggle_control_gpio'
drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'index' not described in 'try_toggle_control_gpio'
drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'value' not described in 'try_toggle_control_gpio'
drivers/net/ethernet/smsc/smc91x.c:2199: warning: Function parameter or member 'nsdelay' not described in 'try_toggle_control_gpio'

Document these parameters.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 5b320b53

drivers/net/ethernet/smsc/smc91x.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -2192,6 +2192,12 @@ MODULE_DEVICE_TABLE(of, smc91x_match);

		/**
		* of_try_set_control_gpio - configure a gpio if it exists
		* @dev: net device
		* @desc: where to store the GPIO descriptor, if it exists
		* @name: name of the GPIO in DT
		* @index: index of the GPIO in DT
		* @value: set the GPIO to this value
		* @nsdelay: delay before setting the GPIO
		*/
		static int try_toggle_control_gpio(struct device *dev,
		struct gpio_desc **desc,

Admin message