Unverified Commit 605b3bec authored Sep 20, 2018 by Trent Piepho Committed by Mark Brown Oct 10, 2018

spi: spidev: Fix OF tree warning logic



spidev will make a big fuss if a device tree node binds a device by
using "spidev" as the node's compatible property.

However, the logic for this isn't looking for "spidev" in the
compatible, but rather checking that the device is NOT compatible with
spidev's list of devices.

This causes a false positive if a device not named "rohm,dh2228fv", etc.
binds to spidev, even if a means other than putting "spidev" in the
device tree was used.  E.g., the sysfs driver_override attribute.

Signed-off-by: Trent Piepho <tpiepho@impinj.com>
Reviewed-by: Jan KundrÃ¡t <jan.kundrat@cesnet.cz>
Tested-by: Jan KundrÃ¡t <jan.kundrat@cesnet.cz>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 5039563e

drivers/spi/spidev.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -725,11 +725,9 @@ static int spidev_probe(struct spi_device *spi)
		* compatible string, it is a Linux implementation thing
		* rather than a description of the hardware.
		*/
		if (spi->dev.of_node && !of_match_device(spidev_dt_ids, &spi->dev)) {
		dev_err(&spi->dev, "buggy DT: spidev listed directly in DT\n");
		WARN_ON(spi->dev.of_node &&
		!of_match_device(spidev_dt_ids, &spi->dev));
		}
		WARN(spi->dev.of_node &&
		of_device_is_compatible(spi->dev.of_node, "spidev"),
		"%pOF: buggy DT: spidev listed directly in DT\n", spi->dev.of_node);

		spidev_probe_acpi(spi);

Admin message