Commit 60528afa authored Nov 14, 2019 by Bob Peterson Committed by Andreas Gruenbacher Nov 14, 2019

gfs2: Don't loop forever in gfs2_freeze if withdrawn



Before this patch, function gfs2_freeze would loop forever if the
filesystem it tries to freeze is withdrawn. That's because function
gfs2_lock_fs_check_clean tries to enqueue the glock of the journal and
the gfs2_glock returns -EIO because you can't enqueue a journaled glock
after a withdraw.

Move the check for file system withdraw inside the loop so that the loop
can end when withdraw occurs.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>

parent f155f5e0

fs/gfs2/super.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -761,12 +761,12 @@ static int gfs2_freeze(struct super_block *sb)
		if (atomic_read(&sdp->sd_freeze_state) != SFS_UNFROZEN)
		goto out;

		for (;;) {
		if (gfs2_withdrawn(sdp)) {
		error = -EINVAL;
		goto out;
		}

		for (;;) {
		error = gfs2_lock_fs_check_clean(sdp, &sdp->sd_freeze_gh);
		if (!error)
		break;

Admin message