Commit 602cae04 authored Dec 19, 2018 by Peter Zijlstra Committed by Ingo Molnar Feb 04, 2019

perf/x86/intel: Delay memory deallocation until x86_pmu_dead_cpu()



intel_pmu_cpu_prepare() allocated memory for ->shared_regs among other
members of struct cpu_hw_events. This memory is released in
intel_pmu_cpu_dying() which is wrong. The counterpart of the
intel_pmu_cpu_prepare() callback is x86_pmu_dead_cpu().

Otherwise if the CPU fails on the UP path between CPUHP_PERF_X86_PREPARE
and CPUHP_AP_PERF_X86_STARTING then it won't release the memory but
allocate new memory on the next attempt to online the CPU (leaking the
old memory).
Also, if the CPU down path fails between CPUHP_AP_PERF_X86_STARTING and
CPUHP_PERF_X86_PREPARE then the CPU will go back online but never
allocate the memory that was released in x86_pmu_dying_cpu().

Make the memory allocation/free symmetrical in regard to the CPU hotplug
notifier by moving the deallocation to intel_pmu_cpu_dead().

This started in commit:

   a7e3ed1e ("perf: Add support for supplementary event registers").

In principle the bug was introduced in v2.6.39 (!), but it will almost
certainly not backport cleanly across the big CPU hotplug rewrite between v4.7-v4.15...

[ bigeasy: Added patch description. ]
[ mingo: Added backporting guidance. ]

Reported-by: He Zhe <zhe.he@windriver.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> # With developer hat on
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> # With maintainer hat on
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: acme@kernel.org
Cc: bp@alien8.de
Cc: hpa@zytor.com
Cc: jolsa@kernel.org
Cc: kan.liang@linux.intel.com
Cc: namhyung@kernel.org
Cc: <stable@vger.kernel.org>
Fixes: a7e3ed1e ("perf: Add support for supplementary event registers").
Link: https://lkml.kernel.org/r/20181219165350.6s3jvyxbibpvlhtq@linutronix.de


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 9e63a789

arch/x86/events/intel/core.c

+11 −5

Original line number	Diff line number	Diff line
		@@ -3558,6 +3558,14 @@ static void free_excl_cntrs(int cpu)
		}

		static void intel_pmu_cpu_dying(int cpu)
		{
		fini_debug_store_on_cpu(cpu);

		if (x86_pmu.counter_freezing)
		disable_counter_freeze();
		}

		static void intel_pmu_cpu_dead(int cpu)
		{
		struct cpu_hw_events *cpuc = &per_cpu(cpu_hw_events, cpu);
		struct intel_shared_regs *pc;
		@@ -3570,11 +3578,6 @@ static void intel_pmu_cpu_dying(int cpu)
		}

		free_excl_cntrs(cpu);

		fini_debug_store_on_cpu(cpu);

		if (x86_pmu.counter_freezing)
		disable_counter_freeze();
		}

		static void intel_pmu_sched_task(struct perf_event_context *ctx,
		@@ -3663,6 +3666,7 @@ static __initconst const struct x86_pmu core_pmu = {
		.cpu_prepare = intel_pmu_cpu_prepare,
		.cpu_starting = intel_pmu_cpu_starting,
		.cpu_dying = intel_pmu_cpu_dying,
		.cpu_dead = intel_pmu_cpu_dead,
		};

		static struct attribute *intel_pmu_attrs[];
		@@ -3703,6 +3707,8 @@ static __initconst const struct x86_pmu intel_pmu = {
		.cpu_prepare = intel_pmu_cpu_prepare,
		.cpu_starting = intel_pmu_cpu_starting,
		.cpu_dying = intel_pmu_cpu_dying,
		.cpu_dead = intel_pmu_cpu_dead,

		.guest_get_msrs = intel_guest_get_msrs,
		.sched_task = intel_pmu_sched_task,
		};

Admin message