Commit 60252323 authored Aug 04, 2018 by Alexandru Gheorghe

drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the logic



A new helper function(__drm_atomic_helper_plane_reset) has been added
for linking a plane with its state and resetting the core
properties(alpha, rotation, etc.) to their default values.
Use that instead of duplicating the logic.

__drm_atomic_helper_plane_reset initializes the alpha property to its
max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE,
so nothing changes regarding the alpha value.

Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180804161530.12275-9-alexandru-cosmin.gheorghe@arm.com

parent 4f4762fc

drivers/gpu/drm/sun4i/sun4i_layer.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -35,9 +35,7 @@ static void sun4i_backend_layer_reset(struct drm_plane *plane)

		state = kzalloc(sizeof(*state), GFP_KERNEL);
		if (state) {
		plane->state = &state->state;
		plane->state->plane = plane;
		plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE;
		__drm_atomic_helper_plane_reset(plane, &state->state);
		plane->state->zpos = layer->id;
		}
		}

Admin message