Commit 600954e6 authored Nov 25, 2019 by Roman Bolshakov Committed by Martin K. Petersen Dec 09, 2019

scsi: qla2xxx: Drop superfluous INIT_WORK of del_work

del_work is already initialized inside qla2x00_alloc_fcport, there's no
need to overwrite it. Indeed, it might prevent complete traversal of
workqueue list.

Fixes: a01c77d2 ("scsi: qla2xxx: Move session delete to driver work queue")
Cc: Quinn Tran <qutran@marvell.com>
Link: https://lore.kernel.org/r/20191125165702.1013-5-r.bolshakov@yadro.com


Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 4c86b037

drivers/scsi/qla2xxx/qla_target.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1265,7 +1265,6 @@ void qlt_schedule_sess_for_deletion(struct fc_port *sess)
		"Scheduling sess %p for deletion %8phC\n",
		sess, sess->port_name);

		INIT_WORK(&sess->del_work, qla24xx_delete_sess_fn);
		WARN_ON(!queue_work(sess->vha->hw->wq, &sess->del_work));
		}

Admin message