HID: wacom: Detect and correct descriptors missing HID_DG_BARRELSWITCH2 (6005a13c) · Commits · 戴 / test

ISDv4 devices have long supported reporting data from each of two barrel switches, but HID_DG_BARRELSWITCH2 itself was only recently standardized. Prior to its adoption, ISDv4 devices would associate the bit indicating the state of the second barrel switch with the "Undefined" 0x000D0000 usage. Although most such devices have explicit support, a few use the HID_GENERIC codepath which ignores the "Undefined" usage. This patch adds code which detects the presence of a pre-standard second barrel switch and corrects the usage value so that the HID_GENERIC code will declare its presence and report its state. Signed-off-by:

Jason Gerecke <jason.gerecke@wacom.com> Reviewed-by:

Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by:

Jiri Kosina <jkosina@suse.cz>

drivers/hid/wacom_sys.c

+24 −0

Original line number	Diff line number	Diff line
		@@ -240,6 +240,30 @@ static void wacom_usage_mapping(struct hid_device *hdev,
		features->touch_max = 1;
		}

		/*
		* ISDv4 devices which predate HID's adoption of the
		* HID_DG_BARELSWITCH2 usage use 0x000D0000 in its
		* position instead. We can accurately detect if a
		* usage with that value should be HID_DG_BARRELSWITCH2
		* based on the surrounding usages, which have remained
		* constant across generations.
		*/
		if (features->type == HID_GENERIC &&
		usage->hid == 0x000D0000 &&
		field->application == HID_DG_PEN &&
		field->physical == HID_DG_STYLUS) {
		int i = usage->usage_index;

		if (i-4 >= 0 && i+1 < field->maxusage &&
		field->usage[i-4].hid == HID_DG_TIPSWITCH &&
		field->usage[i-3].hid == HID_DG_BARRELSWITCH &&
		field->usage[i-2].hid == HID_DG_ERASER &&
		field->usage[i-1].hid == HID_DG_INVERT &&
		field->usage[i+1].hid == HID_DG_INRANGE) {
		usage->hid = HID_DG_BARRELSWITCH2;
		}
		}

		switch (usage->hid) {
		case HID_GD_X:
		features->x_max = field->logical_maximum;

Admin message